How to review MP Environments pull requests
Introduction
The Modernisation Platform Environments repository contains user application infrastructure as code and deployment workflows. This allows users of the Modernisation Platform to manage their own infrastructure and deployments into their various environments.
Notes on reviewing
Only 1 approving review is required for any pull requests which are raised which means that in the majority of cases, members can approve their own PRs with a review being made by another member of their GitHub team.
In certain cases the MP team need to review infrastructure changes being made to ensure that the use-case is deemed acceptable. These include:
Any changes made to files specified in the
.github/CODEOWNERSfile which only show@ministryofjustice/modernisation-platformas an owner e.g.**/platform_*.tffilesAny changes which are highlighted by the
terraform-plan-evaluator.shshell script. This script is built in to thereusable_terraform_plan_apply.ymlworkflow and if any of the resources listed e.g.aws_eks_clusterare found in the Terraform plan stage the build will be marked as failed, preventing deployments.
Process for approving PRs
To approve these PRs at least 1 member of the @ministryofjustice/modernisation-platform Github team will need to add an approving review.
Additionally, in the case of changes which are highlighted by the terraform-plan-evaluator.sh shell script, a comment will be left on the PR as follows:
Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance
This will also add a “Requested Changes” review from the modernisation-platform-ci user. A member of the @ministryofjustice/modernisation-platform Github team will need to dismiss this review in order for the deployment to be merged/applied successfully.
